Format markdown tables#8
Open
fhunleth wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Just saw the CI failures... going to take a look... |
fhunleth
force-pushed
the
markdown-tables
branch
from
29f2b15 to
e6d1537
Compare
Contributor
Author
|
Fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
The main difference from #7 is that I ended up padding the final column. Leaving it ragged was going to make a special case in the code. I'm not sure what the gold standard markdown formatter is, but https://codebeautify.org/markdown-formatter also pads out the final column
I started going down the path of fixing up malformed tables (row with extra columns, etc.) and quickly ran into EarmarkParser not handling them in ways that were fixable. I think those cases will need some EarmarkParser updates if they are common.
At the very least, I think this supports my use cases.