Enterprise Linux 8 and Debian 12 support (beta 1.21) - #215
Merged
Conversation
… Qt5 compatibility
nbolton
changed the title
nbolton
changed the title
…gic and remove Wayland support option
…or proper QByteArray handling
setChildProcessModifier (6.0), Qt::SingleShotConnection (6.0) and the single-overload QProcess::finished are Qt6-only. Guard them for the el8/el9 Qt5 build: skip the child-process modifier, emulate single-shot via self-disconnect, and disambiguate finished with QOverload. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
NetworkMonitor: use QAbstractSocket::IPv6Protocol (Qt5 has no QHostAddress::IPv6Protocol) and std::sort over iterators since Qt5's QList doesn't satisfy the C++20 ranges concepts std::ranges::sort needs. ClientConfigDialog: disambiguate QDoubleSpinBox::valueChanged with QOverload. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
SettingsDialog: disambiguate QComboBox::currentIndexChanged / QSpinBox::valueChanged with QOverload (Qt5 has the extra QString overload). LineEditValidator: QStyle::name() is Qt 6.1+; fall back to objectName() on Qt5. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
NewScreenWidget: QLabel::pixmap() returns a deprecated pointer on Qt5; use grab() there (by-value pixmap() on Qt6). Man page generation runs synergy-core --help, which segfaults on the Qt5 build; skip it on Qt5 so it doesn't gate the build (test-package still runs the installed binary). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
FeatureHandler: disambiguate QComboBox::currentIndexChanged. ActivationDialog and LicenseApiClient: add <QDebug> (Qt 5.13 doesn't pull it in transitively). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Qt5's QCommandLineParser::helpText() (called in CoreArgParser's ctor) dereferences QCoreApplication, which crashes since QApplication is built later. Construct a display-less QCoreApplication for the help/version fast paths and destroy it before the real QApplication. No-op on Qt6. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The synergy-core crash it diagnosed is fixed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://symless.atlassian.net/browse/S1-2152
https://symless.atlassian.net/browse/S1-2163