fix: link failure on macOS 15+ due to missing libpthread - #207
Open
BH3GEI wants to merge 1 commit into
Open
Conversation
Modern macOS (15+) bundles pthread into libSystem with no separate libpthread, so -lpthread fails at link time. Use find_package(Threads) and Threads::Threads on Apple platforms while keeping the existing check_library_exists path for Linux/BSD.
Member
|
Thanks for the PR, I will review. Is this relevant to upstream Deskflow? |
Contributor
|
It sure is. As we use the same logic to find pthread in Deskflow. This should be moved to the deskflow repo imho |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Building on macOS 15+ (Sequoia/Tahoe) with Xcode 16+ fails at link time:
Modern macOS consolidates pthread into libSystem — there is no standalone
libpthreadto link against. The existingcheck_library_exists("pthread" ...)check passes (becausepthread_createexists in libSystem), but the resulting-lpthreadflag fails with the new linker.Fix: On Apple platforms, use CMake's
find_package(Threads)+Threads::Threadsinstead of raw-lpthread. This correctly resolves to the system threading support without requiring a standalone library. TheHAVE_PTHREADvariable is still set soArchMultithreadPosix.his included as before. Linux/BSD path is unchanged.Test plan
HAVE_PTHREADcorrectly defined,ArchMultithreadPosixcompilesif(APPLE))