Re-fork from Deskflow v1.26 to Synergy v1.21-beta

.github/actions/get-version/action.yml

@@ -1,15 +1,30 @@
 name: "Get version"
-description: "Gets the version number from GitHub environment"
+description: >
+  Computes the build version via extra/cmake/SaveVersion.cmake — runs the same
+  synergy_compute_version() the build uses, so the CI-side version (used in
+  package filenames, S3 paths, release titles) matches what binaries report.
+
+outputs:
+  version:
+    description: "Synergy version (e.g. 1.21.0, 1.21.0-snapshot+r42, 1.21.0-dev)"
+    value: ${{ steps.compute.outputs.version }}
 
 runs:
   using: "composite"
-
   steps:
-    - run: |
-        echo "DESKFLOW_VERSION=$(git describe --long | sed 's/-/./g;s/v//g'  | grep -o '^[0-9]*.[0-9]*.[0-9]*.[0-9]*')">> $GITHUB_ENV
-        if [[ "$GITHUB_REF" == *"tags/v"* ]]; then
-          echo "DESKFLOW_PACKAGE_VERSION=$(echo $GITHUB_REF | sed 's,refs/tags/v,,g')">> $GITHUB_ENV
-        else
-          echo "DESKFLOW_PACKAGE_VERSION=continuous">> $GITHUB_ENV
-        fi
+    - id: compute
       shell: bash
+      run: |
+        # Container jobs bind-mount the workspace owned by the host user while
+        # running as root, so git rejects it as dubious-owned and the SHA lookup
+        # in Version.cmake fails silently, degrading the version to a no-SHA form.
+        git config --global --add safe.directory "$GITHUB_WORKSPACE"
+        mkdir -p build
+        cmake \
+          -DVERSION_FILE=build/VERSION \
+          -DSYNERGY_VERSION_RELEASE=${SYNERGY_VERSION_RELEASE:-false} \
+          -DSYNERGY_VERSION_SNAPSHOT=${SYNERGY_VERSION_SNAPSHOT:-false} \
+          -P extra/cmake/SaveVersion.cmake
+        version=$(cat build/VERSION)
+        echo "Computed version: $version"
+        echo "version=$version" >> "$GITHUB_OUTPUT"

.github/actions/install-dependencies/action.yml

@@ -34,9 +34,12 @@ runs:
           elif [ "$RUNNER_OS" == "Linux" ]; then
             if [ ${{inputs.like}} == "debian" ]; then
               apt update -qqq > /dev/null
+              # qt6-l10n-tools + qt6-tools-dev-tools provide lconvert/lupdate/lrelease that
+              # qt6-tools-dev's LinguistTools cmake references but doesn't always pull in.
               apt install -qqq cmake build-essential ninja-build \
                 xorg-dev libx11-dev libxtst-dev libssl-dev \
                 libglib2.0-dev libxkbfile-dev qt6-base-dev qt6-tools-dev \
+                qt6-l10n-tools qt6-tools-dev-tools \
                 libgtk-3-dev libgtest-dev libgmock-dev \
                 libei-dev libportal-dev help2man doxygen -y >/dev/null
             elif [ ${{inputs.like}} == "fedora" ]; then

.github/actions/lint-clang/action.yml

@@ -1,5 +1,5 @@
 name: "Lint Clang"
-description: "Checks for Clang lint errors and posts a helpful comment"
+description: "Fails CI if any source file doesn't match clang-format"
 
 runs:
   using: "composite"
@@ -43,48 +43,20 @@ runs:
         if-no-files-found: error
 
     - name: Set summary
-      id: summary
       if: steps.changes.outputs.diff
       run: |
         code_block="\`\`\`"
-
         clang_version=$(clang-format --version | sed -n 's/^.*version //p')
+        cat <<EOF >> $GITHUB_STEP_SUMMARY
+        ❌ \`clang-format\` \`v${clang_version}\`: changes don't match the code style.
 
-        summary=$(cat <<EOF
-        ❌ \`clang-format\` \`v${clang_version}\`: It looks like your changes don't match our code style.
-
-        🛠️ Please either run \`clang-format -i\` on the file or apply this patch with \`git apply\`:
-
-        [\`${{ steps.changes.outputs.file }}\`](${{ steps.upload.outputs.artifact-url }})
+        Run \`clang-format -i\` on the changed files, or download the \`clang-format-diff\` artifact and \`git apply\` it.
         $code_block diff
         ${{ steps.changes.outputs.diff }}
         $code_block
-
-        Hint: Install the right version of \`clang-format\`, e.g.: \`pipx install --global clang-format==${clang_version}\`
-        EOF
-        )
-        echo "$summary" >> $GITHUB_STEP_SUMMARY
-
-        pr_comment=$(cat <<EOF
-        ### Lint result
-
-        $summary
         EOF
-        )
-
-        file="ci-summary.md"
-        echo "$pr_comment" | tee $file
-        echo "file=$file" >> $GITHUB_OUTPUT
       shell: bash
 
-    - name: Upload CI summary as artifact
-      if: steps.summary.outputs.file
-      uses: actions/upload-artifact@v7
-      with:
-        name: summary-clang-format
-        path: ${{ steps.summary.outputs.file }}
-        if-no-files-found: error
-
     - name: Fail if diff exists
       if: steps.changes.outputs.diff
       run: exit 1

.github/actions/run-tests/action.yml

@@ -1,12 +1,7 @@
 name: "Run tests"
-description: "Runs both unit tests and integration tests and appends to a PR comment"
+description: "Runs both unit tests and legacy tests"
 
 inputs:
-  job:
-    description: "The job name to append to the PR comment"
-    required: true
-    default: "unknown"
-
   bin-dir:
     description: "The directory containing the test binaries"
     default: "build/bin"
@@ -20,11 +15,12 @@ runs:
       env:
         QT_QPA_PLATFORM: offscreen
       run: |
-        ctest --test-dir  "build/src/unittests" --output-on-failure
-        result=$?
+        ctest --test-dir "build/src/unittests" --output-on-failure || result=1
+        ctest --test-dir "build/extra/src/unittests" --output-on-failure || result=1
 
-        if [ $result -ne 0 ]; then
-          echo "Unit tests failed with code: $result" >> $GITHUB_STEP_SUMMARY
+        if [ "${result:-0}" -ne 0 ]; then
+          echo "Unit tests failed" >> $GITHUB_STEP_SUMMARY
+          exit 1
         fi
       shell: bash
       continue-on-error: true
@@ -43,39 +39,6 @@ runs:
       shell: bash
       continue-on-error: true
 
-    - name: Get test results
-      id: results
-      run: |
-        pass="✅ Pass"
-        fail="❌ Fail"
-        unit_tests_outcome="${{ steps.unit-tests.outcome }}"
-        legacy_tests_outcome="${{ steps.legacy-tests.outcome }}"
-        unit_tests=$( [ "$unit_tests_outcome" = "success" ] && echo $pass || echo $fail )
-        legacy_tests=$( [ "$legacy_tests_outcome" = "success" ] && echo $pass || echo $fail )
-        echo "unit-tests=$unit_tests" >> $GITHUB_OUTPUT
-        echo "legacy-tests=$legacy_tests" >> $GITHUB_OUTPUT
-      shell: bash
-
-    - name: Summary row
-      id: row
-      run: |
-        file="row-${{ inputs.job }}.md"
-
-        row=""
-        row+="| ${{ inputs.job }} "
-        row+="| ${{ steps.results.outputs.unit-tests }} "
-        row+="| ${{ steps.results.outputs.legacy-tests }} "
-        echo "$row" > $file
-
-        echo "file=$file" > $GITHUB_OUTPUT
-      shell: bash
-
-    - name: Save summary row
-      uses: actions/upload-artifact@v7
-      with:
-        name: test-result-${{ inputs.job }}
-        path: ${{ steps.row.outputs.file }}
-
     - name: Check test outcome
       if: (steps.unit-tests.outcome != 'success' || steps.legacy-tests.outcome != 'success')
       run: |