Skip to content

Remove protocol downgrade restriction - #161

Merged
nbolton merged 5 commits into
masterfrom
no-downgrade-restrict
Mar 3, 2026
Merged

nbolton merged 5 commits into
masterfrom
no-downgrade-restrict

Conversation

@nbolton

@nbolton nbolton commented Mar 3, 2026 •

Copy link
Copy Markdown
Member

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the client/server protocol handshake so the client can negotiate (downgrade) to the server’s reported protocol minor version instead of rejecting older servers.

Changes:

  • Removed the client-side isCompatible() compatibility table and related rejection logic.
  • Updated Client::handleHello to always respond with helloBackMinor = minor from the server hello.
  • Tweaked hello/hello-back log verbosity and messaging.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/lib/client/Client.h Removes the isCompatible() declaration as part of simplifying handshake logic.
src/lib/client/Client.cpp Removes compatibility table + rejection path; always negotiates the server’s protocol minor in handleHello.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/lib/client/Client.cpp Outdated
Comment thread src/lib/client/Client.cpp Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/lib/client/Client.cpp Outdated
Comment thread src/lib/client/Client.cpp

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/lib/client/Client.cpp
@nbolton
nbolton merged commit db1b7ef into master Mar 3, 2026
31 checks passed
@nbolton
nbolton deleted the no-downgrade-restrict branch March 3, 2026 13:07
@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown

✅ Merge build was successful.
Version: 1.20.1-snapshot+r7
Run: CI (success)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants