[web-profiler-bundle] Remove deprecated collect_serializer_data option

[nicolas-grekas]

Q	A
License	MIT
Doc issue/PR	-

Since symfony/framework-bundle 8.1: Setting the "framework.profiler.collect_serializer_data" configuration option is deprecated. It will be removed in version 9.0.

[symfony-recipes-bot]

Thanks for the PR 😍

How to test these changes in your application

1. Define the SYMFONY_ENDPOINT environment variable:

   # On Unix-like (BSD, Linux and macOS)
   export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1538/index.json
   # On Windows
   SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1538/index.json

2. Install the package(s) related to this recipe:

   composer req symfony/flex
   composer req 'symfony/web-profiler-bundle:^8.1'

3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

   # On Unix-like (BSD, Linux and macOS)
   unset SYMFONY_ENDPOINT
   # On Windows
   SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

symfony/web-profiler-bundle

3.3 vs 5.3

diff --git a/symfony/web-profiler-bundle/3.3/config/packages/dev/web_profiler.yaml b/symfony/web-profiler-bundle/3.3/config/packages/dev/web_profiler.yaml
deleted file mode 100644
index e92166a7..00000000
--- a/symfony/web-profiler-bundle/3.3/config/packages/dev/web_profiler.yaml
+++ /dev/null
@@ -1,6 +0,0 @@
-web_profiler:
-    toolbar: true
-    intercept_redirects: false
-
-framework:
-    profiler: { only_exceptions: false }
diff --git a/symfony/web-profiler-bundle/3.3/config/packages/test/web_profiler.yaml b/symfony/web-profiler-bundle/3.3/config/packages/test/web_profiler.yaml
deleted file mode 100644
index 03752de2..00000000
--- a/symfony/web-profiler-bundle/3.3/config/packages/test/web_profiler.yaml
+++ /dev/null
@@ -1,6 +0,0 @@
-web_profiler:
-    toolbar: false
-    intercept_redirects: false
-
-framework:
-    profiler: { collect: false }
diff --git a/symfony/web-profiler-bundle/5.3/config/packages/web_profiler.yaml b/symfony/web-profiler-bundle/5.3/config/packages/web_profiler.yaml
new file mode 100644
index 00000000..17893da1
--- /dev/null
+++ b/symfony/web-profiler-bundle/5.3/config/packages/web_profiler.yaml
@@ -0,0 +1,15 @@
+when@dev:
+    web_profiler:
+        toolbar: true
+        intercept_redirects: false
+
+    framework:
+        profiler: { only_exceptions: false }
+
+when@test:
+    web_profiler:
+        toolbar: false
+        intercept_redirects: false
+
+    framework:
+        profiler: { collect: false }
diff --git a/symfony/web-profiler-bundle/3.3/config/routes/dev/web_profiler.yaml b/symfony/web-profiler-bundle/3.3/config/routes/dev/web_profiler.yaml
deleted file mode 100644
index c82beff2..00000000
--- a/symfony/web-profiler-bundle/3.3/config/routes/dev/web_profiler.yaml
+++ /dev/null
@@ -1,7 +0,0 @@
-web_profiler_wdt:
-    resource: '@WebProfilerBundle/Resources/config/routing/wdt.xml'
-    prefix: /_wdt
-
-web_profiler_profiler:
-    resource: '@WebProfilerBundle/Resources/config/routing/profiler.xml'
-    prefix: /_profiler
diff --git a/symfony/web-profiler-bundle/5.3/config/routes/web_profiler.yaml b/symfony/web-profiler-bundle/5.3/config/routes/web_profiler.yaml
new file mode 100644
index 00000000..8d85319f
--- /dev/null
+++ b/symfony/web-profiler-bundle/5.3/config/routes/web_profiler.yaml
@@ -0,0 +1,8 @@
+when@dev:
+    web_profiler_wdt:
+        resource: '@WebProfilerBundle/Resources/config/routing/wdt.xml'
+        prefix: /_wdt
+
+    web_profiler_profiler:
+        resource: '@WebProfilerBundle/Resources/config/routing/profiler.xml'
+        prefix: /_profiler
diff --git a/symfony/web-profiler-bundle/3.3/manifest.json b/symfony/web-profiler-bundle/5.3/manifest.json
index cb84a249..be741281 100644
--- a/symfony/web-profiler-bundle/3.3/manifest.json
+++ b/symfony/web-profiler-bundle/5.3/manifest.json
@@ -4,5 +4,8 @@
     },
     "copy-from-recipe": {
         "config/": "%CONFIG_DIR%/"
+    },
+    "conflict": {
+        "symfony/framework-bundle": "<5.3"
     }
 }

5.3 vs 6.1

diff --git a/symfony/web-profiler-bundle/5.3/config/packages/web_profiler.yaml b/symfony/web-profiler-bundle/6.1/config/packages/web_profiler.yaml
index 17893da1..1e039b76 100644
--- a/symfony/web-profiler-bundle/5.3/config/packages/web_profiler.yaml
+++ b/symfony/web-profiler-bundle/6.1/config/packages/web_profiler.yaml
@@ -1,15 +1,11 @@
 when@dev:
     web_profiler:
         toolbar: true
-        intercept_redirects: false
 
     framework:
-        profiler: { only_exceptions: false }
+        profiler:
+            collect_serializer_data: true
 
 when@test:
-    web_profiler:
-        toolbar: false
-        intercept_redirects: false
-
     framework:
         profiler: { collect: false }
diff --git a/symfony/web-profiler-bundle/5.3/manifest.json b/symfony/web-profiler-bundle/6.1/manifest.json
index be741281..fceb97f4 100644
--- a/symfony/web-profiler-bundle/5.3/manifest.json
+++ b/symfony/web-profiler-bundle/6.1/manifest.json
@@ -6,6 +6,6 @@
         "config/": "%CONFIG_DIR%/"
     },
     "conflict": {
-        "symfony/framework-bundle": "<5.3"
+        "symfony/framework-bundle": "<6.1"
     }
 }

6.1 vs 7.3

diff --git a/symfony/web-profiler-bundle/6.1/config/packages/web_profiler.yaml b/symfony/web-profiler-bundle/7.3/config/packages/web_profiler.yaml
index 1e039b76..0eac3c98 100644
--- a/symfony/web-profiler-bundle/6.1/config/packages/web_profiler.yaml
+++ b/symfony/web-profiler-bundle/7.3/config/packages/web_profiler.yaml
@@ -8,4 +8,6 @@ when@dev:
 
 when@test:
     framework:
-        profiler: { collect: false }
+        profiler:
+            collect: false
+            collect_serializer_data: true
diff --git a/symfony/web-profiler-bundle/6.1/config/routes/web_profiler.yaml b/symfony/web-profiler-bundle/7.3/config/routes/web_profiler.yaml
index 8d85319f..b3b7b4b0 100644
--- a/symfony/web-profiler-bundle/6.1/config/routes/web_profiler.yaml
+++ b/symfony/web-profiler-bundle/7.3/config/routes/web_profiler.yaml
@@ -1,8 +1,8 @@
 when@dev:
     web_profiler_wdt:
-        resource: '@WebProfilerBundle/Resources/config/routing/wdt.xml'
+        resource: '@WebProfilerBundle/Resources/config/routing/wdt.php'
         prefix: /_wdt
 
     web_profiler_profiler:
-        resource: '@WebProfilerBundle/Resources/config/routing/profiler.xml'
+        resource: '@WebProfilerBundle/Resources/config/routing/profiler.php'
         prefix: /_profiler

7.3 vs 8.1

diff --git a/symfony/web-profiler-bundle/7.3/config/packages/web_profiler.yaml b/symfony/web-profiler-bundle/8.1/config/packages/web_profiler.yaml
index 0eac3c98..456fc45b 100644
--- a/symfony/web-profiler-bundle/7.3/config/packages/web_profiler.yaml
+++ b/symfony/web-profiler-bundle/8.1/config/packages/web_profiler.yaml
@@ -3,11 +3,9 @@ when@dev:
         toolbar: true
 
     framework:
-        profiler:
-            collect_serializer_data: true
+        profiler: true
 
 when@test:
     framework:
         profiler:
             collect: false
-            collect_serializer_data: true