Don't add processor to all loggers if tags specify a channel or handler - #513
Merged
Merged
Conversation
Member
Author
|
Decided to put in in one line instead. |
HypeMC
force-pushed
the
fix-autoconfigure-processor
branch
2 times, most recently
from
September 5, 2025 22:46
fa17522 to
b8070aa
Compare
GromNaN
approved these changes
Sep 24, 2025
HypeMC
force-pushed
the
fix-autoconfigure-processor
branch
2 times, most recently
from
September 24, 2025 13:11
5711cf8 to
e4a6633
Compare
GromNaN
force-pushed
the
fix-autoconfigure-processor
branch
from
September 24, 2025 13:45
e4a6633 to
09b4bae
Compare
Member
|
Thank you @HypeMC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to symfony/symfony#61526.
When you add a custom processor to a specific channel or handler, it gets added to all channels because
ProcessorInterfaceis registered for autoconfiguration.Here's a simple example:
You'd expect this processor to be registered only for
my_channel, but due to autoconfiguration it's added to every channel.The workaround is to disable autoconfiguration and add an explicit tag.
This PR ensures a processor is not added to all channels when an explicit channel or handler is configured.