Harden error handling in Deepgram and MiniMax bridges#2225
Open
chr-hertel wants to merge 1 commit into
Open
Conversation
carsonbot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the late-joiner Deepgram and MiniMax bridges up to the v0.10/v0.11 error-handling baseline.
HttpStatusErrorHandlingTrait, validating HTTP status before parsing and before streaming (previously it parsed responses blindly, so a 401/429/5xx surfaced as an "undefined array key"). Also guards the async polling/download requests, throwsIncompleteStreamExceptionon truncated streams, and usesJsonBodyEncodingTraitfor request bodies.HttpStatusErrorHandlingTraitso non-2xx responses raise typed exceptions (AuthenticationException,ServerException, …) instead of a genericRuntimeException, while preserving its richer error-message extraction as a fallback. Also usesJsonBodyEncodingTrait.Error-path tests added for both bridges. No CHANGELOG entries (bug fix, both bridges unreleased).