Fix retry loop exhausting API quota when initialization fails#16
Merged
Conversation
Write InitializationSignature at the start of InitializeDevice() instead of at the end. Previously, if createStates() failed (device offline) or setupSettings() was interrupted (rate limit hit mid-way), the signature was never written. Any subsequent IM_CHANGESTATUS or CONNECTED event would re-trigger InitializeDevice(), burning through the 1000 requests/day limit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
TillBrede
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
InitializeDevice()is called and the device is offline or the API rate limit is hit mid-way throughsetupSettings(), theInitializationSignatureattribute was only written at the end of the successful code path (inside theif ($this->createStates())block).This meant that on every subsequent trigger (e.g.
IM_CHANGESTATUS,FM_CONNECT,CONNECTEDevent),needsInitialization()returnedtrueandInitializeDevice()was called again — exhausting the daily API quota of 1000 requests.Fix
Move
WriteAttributeString('InitializationSignature', ...)to the beginning ofInitializeDevice(), before any API calls. This ensures the signature is stored immediately, so repeated initialization attempts are suppressed even when the device is offline or an error occurs mid-initialization.Changes
Home Connect Device/module.php: MoveWriteAttributeString('InitializationSignature', ...)to the start ofInitializeDevice()library.json: Bump build to 11🤖 Generated with Claude Code