Remove redundant enclosing lock from SyncCommitteeHeadStateCache - #19
Open
syjn99 wants to merge 1 commit into
Open
Remove redundant enclosing lock from SyncCommitteeHeadStateCache#19syjn99 wants to merge 1 commit into
syjn99 wants to merge 1 commit into
Conversation
The SyncCommitteeHeadStateCache wraps lru.Cache which already has internal locking. The external sync.RWMutex is redundant and adds unnecessary overhead. Remove the lock field and all Lock/Unlock/ RLock/RUnlock calls from Put() and Get(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync.RWMutexfromSyncCommitteeHeadStateCachestruct inbeacon-chain/cache/sync_committee_head_state.golru.Cache(hashicorp/golang-lru) already provides internal thread-safe locking, making the external lock unnecessary overheadlockfield, allLock()/Unlock()/RLock()/RUnlock()calls fromPut()andGet(), and unusedsyncimportFixes OffchainLabs#13723
Test plan
gofmtandgoimportspassbazel build //beacon-chain/cache/...passesbazel test //beacon-chain/cache/...— 2/2 tests pass, no new failures vs baseline🤖 Generated with Claude Code