fix : added rating range validation and HTML escaping to send-review route - #6
Open
tmdeveloper007 wants to merge 1 commit into
Open
Conversation
- Validate rating is integer between 1 and 5 before email generation - Escape HTML special characters in name, email, and review fields - Return 400 response for missing fields and invalid rating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done:
Added server-side validation to ensure the rating field is an integer between 1 and 5 before the email is generated. Also escaped HTML special characters in name, email, and review fields to prevent accidental HTML injection in email clients.
Changes Made:
Impact it Made:
Note: Please assign this PR to the
tmdeveloper007account.