fix : added error handling and input validation to trackActivity utility - #4
Open
tmdeveloper007 wants to merge 1 commit into
Open
fix : added error handling and input validation to trackActivity utility#4tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
- Add input validation for userId (must be non-empty string) and type - Wrap all async database operations in try/catch to prevent unhandled rejections - Handle both select and insert errors explicitly - Add security test coverage in security-tests/activity-util.test.cjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes (upstream issues disabled — no issue created).
Summary of What Has Been Done:
Added input validation and comprehensive error handling to the trackActivity utility in lib/activity.js. The function previously had no validation on userId or type parameters and no try/catch, meaning invalid inputs or database errors would cause unhandled promise rejections silently. Now the function validates that userId and type are non-empty strings before making any database calls, wraps all Supabase operations in try/catch, and logs errors gracefully instead of crashing.
Changes Made:
Impact it Made:
Note: Please assign this PR to the
tmdeveloper007account.