Skip to content

Update Processing Lambda Unit Tests & Refactor for ruff#10

Merged
Alrobbertz merged 5 commits into
swxsoc:mainfrom
Alrobbertz:refactor-processinggits
Jun 3, 2026
Merged

Update Processing Lambda Unit Tests & Refactor for ruff#10
Alrobbertz merged 5 commits into
swxsoc:mainfrom
Alrobbertz:refactor-processinggits

Conversation

@Alrobbertz

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 14, 2026 19:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the test/linting setup toward newer dependencies and Ruff, while making minor formatting/docstring adjustments in the Lambda processor code.

Changes:

  • Replaces Black/Flake8 dev tooling with Ruff and updates pytest/moto versions.
  • Updates GitHub Actions workflows for testing, coverage upload, and Ruff linting.
  • Removes the local Lambda config file and applies minor import/docstring formatting changes.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
requirements.dev.txt Updates test/dev dependencies and switches lint tooling to Ruff.
lambda_function/tests/test_processor.py Refactors imports and removes pre-import config path setup.
lambda_function/src/lambda.py Adds type annotations and rewrites handler docstring.
lambda_function/src/file_processor/file_processor.py Applies Ruff-style import ordering and spacing.
lambda_function/src/config.yaml Removes the mission configuration file.
.github/workflows/testing.yml Updates test workflow runner/actions/dependency install/coverage upload.
.github/workflows/codestyle.yml Replaces Black/Flake8 workflow with Ruff workflow.
Comments suppressed due to low confidence (1)

lambda_function/src/config.yaml:1

  • Deleting the only checked-in SDC AWS config leaves the Lambda image without the mission/bucket/instrument settings that file_processor still needs via sdc_aws_utils.config (get_instrument_bucket, get_instrument_package, and the filename parser). The previous tests explicitly pointed SDC_AWS_CONFIG_FILE_PATH at this file before importing the processor, so removing it without providing an alternative config path will break local tests and deployments that rely on the copied src tree.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lambda_function/tests/test_processor.py Outdated
Comment thread .github/workflows/testing.yml
Comment thread .github/workflows/testing.yml
Comment thread .github/workflows/codestyle.yml
Comment thread lambda_function/src/lambda.py
Comment thread lambda_function/tests/test_processor.py
Comment thread .github/workflows/testing.yml
@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@Alrobbertz Alrobbertz merged commit 67770c4 into swxsoc:main Jun 3, 2026
5 checks passed
@Alrobbertz Alrobbertz deleted the refactor-processinggits branch June 3, 2026 15:16
@Alrobbertz Alrobbertz mentioned this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants