Update Processing Lambda Unit Tests & Refactor for ruff#10
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the test/linting setup toward newer dependencies and Ruff, while making minor formatting/docstring adjustments in the Lambda processor code.
Changes:
- Replaces Black/Flake8 dev tooling with Ruff and updates pytest/moto versions.
- Updates GitHub Actions workflows for testing, coverage upload, and Ruff linting.
- Removes the local Lambda config file and applies minor import/docstring formatting changes.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
requirements.dev.txt |
Updates test/dev dependencies and switches lint tooling to Ruff. |
lambda_function/tests/test_processor.py |
Refactors imports and removes pre-import config path setup. |
lambda_function/src/lambda.py |
Adds type annotations and rewrites handler docstring. |
lambda_function/src/file_processor/file_processor.py |
Applies Ruff-style import ordering and spacing. |
lambda_function/src/config.yaml |
Removes the mission configuration file. |
.github/workflows/testing.yml |
Updates test workflow runner/actions/dependency install/coverage upload. |
.github/workflows/codestyle.yml |
Replaces Black/Flake8 workflow with Ruff workflow. |
Comments suppressed due to low confidence (1)
lambda_function/src/config.yaml:1
- Deleting the only checked-in SDC AWS config leaves the Lambda image without the mission/bucket/instrument settings that
file_processorstill needs viasdc_aws_utils.config(get_instrument_bucket,get_instrument_package, and the filename parser). The previous tests explicitly pointedSDC_AWS_CONFIG_FILE_PATHat this file before importing the processor, so removing it without providing an alternative config path will break local tests and deployments that rely on the copiedsrctree.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.