tweak(persons): let the filters be closed from the navbar on mobile - #5409
tweak(persons): let the filters be closed from the navbar on mobile#5409ux-git wants to merge 2 commits into
Conversation
Opening the filters on a phone replaced the list, and the button that closes them went with it. The page header now reads Filters with All persons under it while they are open, and its back arrow brings the list back. The filters keep their own heading on wider screens, where they sit next to the list.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| import AssignmentGroup from '../assignment_group'; | ||
| import Tabs from '@components/tabs'; | ||
| import TabLabel from '@components/tab_label_with_badge'; | ||
| import { PersonsFilterProps } from './index.types'; |
There was a problem hiding this comment.
🔍 New type bypasses path aliases
The PersonsFilterProps import uses a relative path. Repository rules require TypeScript path aliases for imports.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. Important Approval pendingCodeRabbit has no unresolved comments, but it could not review the latest commit because the review limit was reached. Follow the review guidance in this comment to continue. Walkthrough
ChangesPersons filter subpage
Merge Risk: ⚪ Minimal · up to Mobile and tablet filter views now present as a Filters subpage with a back action to return to the persons list, while wider layouts retain their existing behavior. No current merge-readiness risk is identified. Sequence Diagram(s)sequenceDiagram
participant PersonsAll
participant PageTitle
participant PersonsFilter
PersonsAll->>PersonsAll: set isFilterSubpage when filter opens below desktop
PersonsAll->>PageTitle: render tr_filters with tr_personsAll and back handler
PersonsAll->>PersonsFilter: render inside padded mobile panel with hideTitle
PageTitle-->>PersonsAll: invoke handleCloseFilter on back
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Tick the box to add this pull request to the merge queue (same as
|
The filters can be scrolled well past where the list starts, so closing them from the navbar left the page in the middle of the list.
|
1 participant
On a phone the filters replace the person list, and the button that closes them goes with it — leaving Search as the only way out.
While the filters are open, the page header now reads "Filters" with "All persons" under it, and its back arrow returns to the list. The filters drop their own heading there to avoid repeating the title; on wider screens, where they sit beside the list, nothing changes.
Type of change