Skip to content

tweak(persons): show the person name under the page title #5408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ux-git wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tweak(persons): show the person name under the page title #5408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1caa0dd
tweak(persons): show the person name under the page title
ux-git Sep 4, 2026
5c4e694
fix(persons): read the page title name from the route
ux-git Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/pages/persons/person_details/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ const PersonDetails = () => {

const { isAdmin } = useCurrentUser();

const { isNewPerson, isBaptized, male, isConnected } = usePersonDetails();
const { isNewPerson, isBaptized, male, isConnected, personName } =
usePersonDetails();

return (
<Box
Expand All @@ -38,6 +39,7 @@ const PersonDetails = () => {
>
<PageTitle
title={isNewPerson ? t('tr_addNewPerson') : t('tr_editPerson')}
secondaryTitle={isNewPerson ? undefined : personName}
buttons={<PersonButtonActions />}
/>

Expand Down
21 changes: 20 additions & 1 deletion src/pages/persons/person_details/usePersonDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { useAtom, useAtomValue } from 'jotai';
import { personCurrentDetailsState, personsState } from '@states/persons';
import { personSchema } from '@services/dexie/schema';
import { congAccountConnectedState } from '@states/app';
import { fullnameOptionState } from '@states/settings';
import { buildPersonFullname } from '@utils/common';

const usePersonDetails = () => {
const { id } = useParams();
Expand All @@ -15,11 +17,28 @@ const usePersonDetails = () => {

const persons = useAtomValue(personsState);
const isConnected = useAtomValue(congAccountConnectedState);
const fullnameOption = useAtomValue(fullnameOptionState);

const isBaptized = useMemo(() => {
return person.person_data.publisher_baptized.active.value;
}, [person]);

// the shared record may still hold the previously opened person until the
// effect below replaces it, so the title is read from the route instead
const personName = useMemo(() => {
const record = isNewPerson
? person
: persons.find((item) => item.person_uid === id);
Comment on lines +29 to +31

@devin-ai-integration devin-ai-integration Bot Sep 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Edited names leave title stale

When an existing person's name changes, personName reads the saved record instead of current edits. The title retains the old name until saving.

Suggested change
const record = isNewPerson
? person
: persons.find((item) => item.person_uid === id);
const record =
isNewPerson || person.person_uid === id
? person
: persons.find((item) => item.person_uid === id);
Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


if (!record) return '';

return buildPersonFullname(
record.person_data.person_lastname.value,
record.person_data.person_firstname.value,
fullnameOption
);
}, [id, isNewPerson, person, persons, fullnameOption]);

const male = useMemo(() => {
return person.person_data.male.value;
}, [person]);
Expand All @@ -45,7 +64,7 @@ const usePersonDetails = () => {
}
}, [id, persons, navigate, isNewPerson, setPerson]);

return { isNewPerson, isBaptized, male, isConnected };
return { isNewPerson, isBaptized, male, isConnected, personName };
};

export default usePersonDetails;
Loading