Skip to content

tweak(locales): shorten long UI labels - #5403

Open
ux-git wants to merge 2 commits into
sws2apps:mainfrom
ux-git:chore/shorter-ui-labels
Open

tweak(locales): shorten long UI labels#5403
ux-git wants to merge 2 commits into
sws2apps:mainfrom
ux-git:chore/shorter-ui-labels

Conversation

@ux-git

@ux-git ux-git commented Sep 4, 2026

Copy link
Copy Markdown
Member

Description

Several UI labels were long enough to wrap or shrink on mobile, and translations of them run considerably longer than the English source. This shortens the wordiest warnings, buttons and tab labels without losing any context, since the surrounding screen already provides it.

Only the English source strings are edited — no keys are renamed and no other locale files are touched, so existing translations stay attached and Crowdin just marks them for review.

Warnings

Key Before After
tr_personAlreadyAssignmentWeek This person already has an assignment this week Already assigned this week
tr_repeatedMonthlyWarningDesc This person already has an assignment this month Already assigned this month
tr_notFoundReviewAssignmentQualifications Not found. Review assignment qualifications Not found. Check qualifications
tr_personHasNoAssignmentHistory This person has no assignment history yet No assignment history yet

tr_repeatedMonthlyWarningDesc is shared by the person selector and the helper line under the "Show repeated assignment warning – monthly" toggle in weekend meeting settings. The old sentence started with "This person", which never fitted the settings screen. The new wording works in both places and now reads as a preview of the warning the toggle enables, so the string stays unified.

Buttons

Key Before After
tr_manageUserProfileSettings Manage user account settings Manage user account
tr_assignmentsDeleteMultiple Delete multiple assignments Delete multiple
tr_addCustomMeetingPart Add custom meeting part Add custom part
tr_reactivatePublisher Reactivate this publisher Reactivate publisher

Tabs

The weekly schedules tabs now read "Midweek" and "Weekend", and the publisher records tabs "Active" and "Inactive". The strings themselves are not shortened, because tr_midweekMeeting is used in 15 other places (person page headers, dashboard links, attendance records, the S-88 export) and tr_activePublishers in 6, including the S-21 export file names. Instead the two tab call sites now use the short keys that already exist in the codebase: tr_midweek / tr_weekend and tr_active / tr_inactive. Everything else keeps the full wording.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Devin Review

Trim wordy warnings, tab labels and button labels so they fit better on
mobile and leave more room for longer translations. Tab labels reuse the
existing short keys instead of shortening strings shared with other screens.
@vercel

vercel Bot commented Sep 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
staging-organized-app Ready Ready Preview Sep 4, 2026 7:49pm UTC
test-organized-app Ready Ready Preview Sep 4, 2026 7:49pm UTC

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • src/locales/en/meetings.json is excluded by !**/*.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 6d164aba-59e4-4f88-ab2a-5b55c0b0195a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 8edfa918-1c5f-41f3-8d29-69a7d7eb6abe

📥 Commits

Reviewing files that changed from the base of the PR and between b8c9a3f and 06a855b.

⛔ Files ignored due to path filters (4)
  • src/locales/en/congregation.json is excluded by !**/*.json
  • src/locales/en/general.json is excluded by !**/*.json
  • src/locales/en/meetings.json is excluded by !**/*.json
  • src/locales/en/ministry.json is excluded by !**/*.json
📒 Files selected for processing (2)
  • src/features/reports/publisher_records/publisher_tabs/usePublisherTabs.tsx
  • src/pages/meetings/schedules/useWeeklySchedules.tsx

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The change updates translation keys for publisher status tabs and meeting schedule tabs. No logic, data flow, or control flow changed.

Changes

Tab label translation updates

Layer / File(s) Summary
Update tab label translation keys
src/features/reports/publisher_records/publisher_tabs/usePublisherTabs.tsx, src/pages/meetings/schedules/useWeeklySchedules.tsx
Publisher tabs now use tr_active and tr_inactive. Meeting schedule tabs now use tr_midweek and tr_weekend.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 06a85

This change shortens publisher-status and meeting-schedule tab labels for mobile layouts without altering tab behavior. No current merge-readiness risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description clearly explains the shortened warning, button, and tab labels, including the use of existing short translation keys for the changed tab call sites.
Title check ✅ Passed The title concisely identifies the main change: shortening locale-based UI labels for improved layout on smaller screens.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ux-git ux-git changed the title chore(locales): shorten long UI labels in English source tweak(locales): shorten long UI labels Sep 4, 2026
@mergify

mergify Bot commented Sep 4, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2026

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant