This repository was archived by the owner on Mar 17, 2026. It is now read-only.
AH-436: update library - #39
Open
jeanmurillo95 wants to merge 12 commits into
Open
Conversation
fix: repair lint
jeanmurillo95
requested review from
Fernavarro21,
candradeg,
daniel-hume and
youngcm2
August 30, 2022 18:51
jeanmurillo95
marked this pull request as ready for review
August 30, 2022 18:52
youngcm2
requested review from
a team and
DanStory
and removed request for
a team
August 31, 2022 22:15
DanStory
suggested changes
Aug 31, 2022
DanStory
reviewed
Aug 31, 2022
DanStory
reviewed
Sep 1, 2022
DanStory
suggested changes
Sep 2, 2022
DanStory
suggested changes
Sep 7, 2022
DanStory
left a comment
DanStory
left a comment
Contributor
There was a problem hiding this comment.
There is unaddressed comments, make sure to unhide all comments on the Conversation tab
| const res = await collection.insertOne(eventResult); | ||
|
|
||
| let newDocument = this.toggleId(res.ops[0], false); | ||
| let newDocument = this.toggleId({ id: res.insertedId }, false); |
Contributor
There was a problem hiding this comment.
This needs to be the whole document, not just the id.
|
@jeanmurillo95 there appear to still be several unresolved comments from the last review. |
|
@MatthewEppelsheimer @DanStory Can you please look at this PR? |
DanStory
suggested changes
Sep 28, 2022
| } | ||
| let ourCollection; | ||
| try { | ||
| ourCollection = await db.collection(this.options.name); |
Contributor
There was a problem hiding this comment.
This is missing { strict: true } so it doesn't create the collection out right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surf-shop Change Request
Change Comments
I updated the mongodb library, I also changed some methods and test cases.
Solution description
I updated the mongodb package, I reduced the complexity in some functions, repair some test cases and lint errors.
Linting & unit tests ev
idenceChecklist
PR is ready for code review and approval when each box is checked.
All steps are required, when applicable.
Strikeoutformatting indicates a step is not applicable to this change set.