Skip to content

[windows][arm64] use lld-link to build the compiler#90101

Open
charles-zablit wants to merge 1 commit into
swiftlang:mainfrom
charles-zablit:cz/windows/fix-build-arm64
Open

[windows][arm64] use lld-link to build the compiler#90101
charles-zablit wants to merge 1 commit into
swiftlang:mainfrom
charles-zablit:cz/windows/fix-build-arm64

Conversation

@charles-zablit

@charles-zablit charles-zablit commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

This patch fixes building the toolchain on ARM64 Windows while linking the Stage 0 compiler:

fatal error LNK1322: cannot avoid potential ARM hazard (Cortex-A53 MPCore processor bug #843419) in section 0x1; please consider using compiler option /Gy if it was not used

This is a similar fix as 034a158.

This is a workaround for #90100.

@charles-zablit charles-zablit requested a review from compnerd as a code owner June 22, 2026 16:35
@charles-zablit

Copy link
Copy Markdown
Contributor Author

@swift-ci please test

@charles-zablit charles-zablit requested a review from ktoso June 22, 2026 16:35
@charles-zablit charles-zablit self-assigned this Jun 22, 2026
@compnerd

Copy link
Copy Markdown
Member

Please associate this with an issue; the change itself is fine to unblock, but the underlying issue is something that we need to address in LLVM.

@charles-zablit

Copy link
Copy Markdown
Contributor Author

Please associate this with an issue; the change itself is fine to unblock, but the underlying issue is something that we need to address in LLVM.

There is a comment referencing this issue with a FIXME: https://github.com/swiftlang/swift/pull/90101/changes#diff-c861caa2fcc08744108e542ca836b07e342f537566e8c5f7a21a0e9125331ed9R2848

Is that what you meant?

@compnerd

Copy link
Copy Markdown
Member

Yeah; but can we link that into the commit message as well? But, the issue itself is good enough.

@compnerd compnerd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we actually sink this into CMakeLists.txt and limit to swift-syntax? We should STRONGLY prefer link; its found real issues that lld has let slide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants