[6.4] SILGenApply: Pick up lifetime dependencies from inner function type in static methods.#90097
Open
jckarter wants to merge 1 commit into
Open
[6.4] SILGenApply: Pick up lifetime dependencies from inner function type in static methods.#90097jckarter wants to merge 1 commit into
jckarter wants to merge 1 commit into
Conversation
…n static methods. A static method's AST type gets its lifetime dependencies stuck on the inner function type, as in `(Self.Type) -> @_lifetime (Args...) -> Return`, but SILGenApply was not looking for it there when passing the lifetime dependencies down to CallEmission. Fix for rdar://179057474.
Contributor
Author
|
@swift-ci Please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes a bug where calls into
staticmethods with lifetime dependencies would raise incorrect lifetime dependency errors in some circumstances.Scope: Bug fix.
Issue: rdar://179057474
Risk: Low. There is a small fix to match SILGen's handling of lifetime dependencies to how they are encoded in the AST for static methods.
Reviewed by: @aidan-hall, @kavon
Testing: Swift CI, test case from bug report