Follow a custom SYMROOT when locating the built app#294
Merged
Conversation
The bundled resolver hard-coded BUILD_DIR/BUILD_ROOT to the DerivedData products path, so a project that relocates its products with a custom SYMROOT (e.g. `SYMROOT = $(SRCROOT)/../build/products`) launched against the wrong path and failed with "App path does not exist". Derive both from $(SYMROOT) so TARGET_BUILD_DIR follows the override, matching xcodebuild, and add an oracle fixture pinning the real build settings for the custom-SYMROOT case (#292).
hyzyla
force-pushed
the
issue292-custom-symroot
branch
from
c00c7c7 to
df42677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292. When a project relocates its build products with a custom SYMROOT (e.g.
SYMROOT = $(SRCROOT)/../build/productsin an xcconfig), the bundled resolver kept BUILD_DIR/BUILD_ROOT hard-wired to the DerivedData layout, so TARGET_BUILD_DIR pointed at the wrong place and launch failed with "App path does not exist". This derives BUILD_DIR/BUILD_ROOT from $(SYMROOT) to match xcodebuild, with an oracle fixture capturing the real build settings for the custom-SYMROOT case.