refactor: extract report-renderer into agent-reliability-core — ADR-4 complete - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the last shared primitive — report-renderer (ADR-4) — completing the
agent-reliability-coreextraction. Implements the seam from the design note (#19), approved as closed section set +[render]extra.The seam
Rendering is split into a domain-agnostic presentation model in core and a per-tool adapter that stays in each tool:
agent_reliability_core.report: the closed section vocabulary, the oxbloodTheme(tone→hex + tone→Rich style), and both renderers. HTML/terminal backends are the opt-in[render]extra (jinja2+rich); the model + theme are dependency-free.RunReport/build_report/to_dictunchanged (JSON contract + determinism intact). Newobserver/report_view.to_report()adapter;renderer.pyis now two delegating functions with identical signatures; the stampede template is deleted.Verified
agent_reliability_core.report, and a stampede adapter test).#6b1f2aoxblood token; theme is overridable.ADR-4 complete
All four primitives are now extracted: trace-format, concurrency-core, persona-pack, report-renderer.
agent-reliability-coreis a real, independently-tested distribution the siblings (mcp-probe, costbomb, mockworld) can consume.