fix: allow safe builtins in when: fault conditions - #20
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
when:condition usinglen()(e.g.len(params.text) > 4000) silently never fired: the evaluator stripped all builtins, solenraisedNameError, whicheval_conditionswallows toFalse— quietly disabling the fault. Now a small allowlist (len/min/max/abs/round/sum/int/float/str/bool/any/all) is available; unsafe access (imports,open, attribute gadgets) still fails closed.Found while authoring the community
slackmock (msg_too_longwhenlen(text) > 4000). Unreleased; rides the next tag.