fix: support target-mode backtraces in child containers#233
Merged
Conversation
swananan
force-pushed
the
test/enable-child-container-t-backtrace
branch
2 times, most recently
from
dc7eaa1 to
194acc5
Compare
Publish target-mode proc module offsets only under runtime PID keys tied back to the refreshed proc PID. For a single target process, still accept extra event PIDs when the PID is hidden from the observer /proc. This preserves child-container host TGID lookups without reintroducing visible multi-process aliasing. Treat shared-object exec misses as map-change candidates instead of unresolved aliases. Short polling covers startup races, but exhausted candidates stay dormant until a real map-change proves the PID maps the target before offsets and allowlist entries are published. Filter unmatched map-change events before waking the session and only emit synthetic refresh notifications when target offsets actually change. Serialize dlopen backtrace e2e cases that share the same fixture process. Raise target-mode callback and shared-CFI sampling windows so CI observes late module-offset and CFI refreshes reliably.
swananan
force-pushed
the
test/enable-child-container-t-backtrace
branch
from
194acc5 to
230a43e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish proc module offsets under each runtime PID view used by target-mode events, including child-container event TGIDs. Refresh target-mode backtrace runtime modules from trace event PIDs so late-loaded libraries get offsets and CFI rows before rendering.
Keep executable target-mode map-change events allowlist-gated to avoid pre-allowlist mmap traffic delaying short-lived targets, while shared object targets can still receive pre-allowlist map-change events for first-load detection.