refactor: simplify type handling in ModelDeserializer#5227
Open
Mattias-Sehlstedt wants to merge 1 commit into
Open
refactor: simplify type handling in ModelDeserializer#5227Mattias-Sehlstedt wants to merge 1 commit into
Mattias-Sehlstedt wants to merge 1 commit into
Conversation
Rymert-Mostert
approved these changes
Jul 7, 2026
Rymert-Mostert
left a comment
Rymert-Mostert
left a comment
There was a problem hiding this comment.
My bad. Just looking for the "Dismiss my own review" button.
https://github.com/orgs/community/discussions/120006
Rymert-Mostert
suggested changes
Jul 7, 2026
Mattias-Sehlstedt
force-pushed
the
refactor-model-deserializer
branch
from
af818f2 to
914d3e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-core!
Please fill out the following information to help us review your PR efficiently.
Description
Simplifies the logic in the
ModelDeserializerso that a typedSchemais clearly handled as its own separate scenario with its own processing. Also reduced the surface area againstJackson, so that an upgrade will have a much smaller delta (this change was mainly inspired by this larger-than-necessary delta).Type of Change
Checklist
Screenshots / Additional Context