Skip to content

fix(makernotes): delete the fabricated Google MakerNote parser #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swackhamer merged 2 commits into from
Aug 2, 2026
Merged

fix(makernotes): delete the fabricated Google MakerNote parser #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c52c84
fix(makernotes): delete the fabricated Google MakerNote parser
swackhamer Aug 2, 2026
7d9c9c1
Merge remote-tracking branch 'origin/main' into HEAD
swackhamer Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/parsers/tiff/makernote_dispatcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,11 @@ pub fn dispatch_makernote_with_context_and_values(

// Smartphones
"apple" => Some(Box::new(apple::AppleParser)),
"google" => Some(Box::new(google::GoogleParser)),
// "google" is absent on purpose: there is no fabricated `google`
// parser to dispatch to. ExifTool's real Google MakerNote table
// (Google::HDRPlusMakerNote) is string-id-keyed and reads an
// encrypted/gzipped protobuf blob, not a numeric TIFF IFD, so it
// can't be reached through this Make-keyed dispatch at all.
// "microsoft" | "microsoft corporation" is absent on purpose: there is
// no fabricated `microsoft` parser to dispatch to. MakerNotes.pm has
// no MakerNoteMicrosoft TIFF-IFD dispatch entry at all -- Microsoft's
Expand Down
Loading
Loading