test(makernotes): delete three suites that mirror fabricated tag tables

[swackhamer]

Stacked on #404 (base retargets to main when #404 merges).

Summary

Three of the six undeclared vendor MakerNote suites are deleted rather than declared. Every tag name they assert appears in zero ExifTool 13.59 source files. Declaring them would have pinned invented data as expected behaviour — the exact mechanism that let the fabricated registries/apple.rs survive.

file	tests	disposition
qualcomm_makernotes_tests.rs	17	deleted — parser already removed as fabricated
google_makernotes_tests.rs	17	deleted — all 8 names fabricated
microsoft_makernotes_tests.rs	16	deleted — all 12 names fabricated

50 tests deleted, 0 kept. No production code changed.

Evidence

Ground truth: ExifTool 13.59 at /tmp/oxidex-exiftool-cache/exiftool, searched with /usr/bin/grep -a -r "Name => '<tag>'" lib/ — ExifTool's own tag tables, not the -listx documentation view.

Qualcomm — production already deleted QualcommParser as a fabrication (see the note in makernotes::mod). ClearSight, ClearSightMode, ChromaFlash, OptiZoom, BokehMode, BokehLevel, ZoomLevel, HDRMode, NightMode, LowLightMode, SceneDetection, PhaseDetectAF, FrameMergeCount: 0 hits each. The test file outlived the parser's deletion only because nothing ever compiled it.

Google — Astrophotography, ColorPop, FaceRetouching, HDRPlusMode, MergedFrameCount, NightSight, SceneDetection, SuperResZoom: 0 hits each. ExifTool's only Google MakerNote table is Google::HDRPlusMakerNote, and it is string-id keyed protobuf (ID_FMT => 'str', ids like '1-1', '9-36-1', stored base64-encoded/encrypted/gzipped) — not a numeric TIFF IFD. Its real tags are ImageName, ImageData, TimeLogText, SummaryText, FrameCount, CreateDate.

Microsoft — of the 12 asserted names only LensType (10 other vendors' modules) and PanoramaMode (Kodak, Olympus) exist anywhere, and neither in Microsoft.pm. MakerNotes.pm has no MakerNoteMicrosoft dispatch at all; Microsoft.pm's only GROUPS => { 0 => 'MakerNotes' } table is Microsoft::Stitch, binary data in EXIF tag 0x4748, with tags PanoramicStitchVersion / PanoramicStitchCameraMotion / PanoramicStitchMapType.

This is the identical shape to the already-documented Qualcomm finding: a string-keyed or binary table reached from somewhere other than a Make= MakerNote IFD, re-imagined as a numeric IFD with invented ids and names.

Why deleting passing tests is the right call

google (17/17) and microsoft (16/16) passed once declared. That is the finding, not a reassurance — they pass because makernotes/google.rs and makernotes/microsoft.rs invent exactly the names the tests assert. A test that mirrors a fabricated table cannot detect the fabrication, and leaving it in place would make removing the invented production tags look like a regression.

Not fixed here

makernotes/google.rs, makernotes/microsoft.rs and registries/samsung.rs still emit these fabricated tag names in production. That is a behavioural change across three vendor parsers and needs its own review; it is reported separately and is out of scope for a test-suite PR.

Verification

cargo test --all-features --test integration → 554 passed, 0 failed.

🤖 Generated with Claude Code