fix: guard action lookups against prototypes#16236
Open
vamshikrishnaramasamy wants to merge 1 commit into
Open
fix: guard action lookups against prototypes#16236vamshikrishnaramasamy wants to merge 1 commit into
vamshikrishnaramasamy wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/afb86c5e0459fbbd0a7ca68259a26521ce496e8cOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15525.
This uses own-property checks when resolving named form actions and remote manifest entries, so prototype properties like
toStringandconstructorare treated like missing actions/remotes instead of being invoked.Added a regression test for
?/toStringon a named form action.Tests:
pnpm --dir packages/kit/test/apps/basics exec playwright test test/server.test.js --grep "ignores Object.prototype properties"pnpm --dir packages/kit exec prettier --config ../../.prettierrc --check src/runtime/server/page/actions.js src/runtime/server/remote.js test/apps/basics/test/server.test.jspnpm --dir packages/kit exec tsc --noEmit --pretty false