breaking: stricter server file checks + additional guard possibilities#16235
Open
dummdidumm wants to merge 2 commits into
Open
breaking: stricter server file checks + additional guard possibilities#16235dummdidumm wants to merge 2 commits into
dummdidumm wants to merge 2 commits into
Conversation
closes #12529 - The server-only module guard no longer skips files outside the project `cwd`, so `*.server.*` files imported from workspace packages are now also protected from being bundled into the client. Files in `node_modules` are still skipped to avoid false positives. - Added a `@sveltejs/kit/server-only` export that throws when imported on the client and is a no-op on the server. This is useful for library authors who want to ensure a module is never included in client-side bundles. - `@sveltejs/package` now warns when publishing files that contain `.server.` in their filename or are in a `server` directory, as these are not protected from client-side imports when consumed from `node_modules`. The warning recommends using `@sveltejs/kit/server-only`
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/a1cf3256b980be2594e5648216d5010b08b7fd49Open in |
🦋 Changeset detectedLatest commit: a1cf325 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #12529
cwd, so*.server.*files imported from workspace packages are now also protected from being bundled into the client. Files innode_modulesare still skipped to avoid false positives.@sveltejs/kit/server-onlyexport that throws when imported on the client and is a no-op on the server. This is useful for library authors who want to ensure a module is never included in client-side bundles.@sveltejs/packagenow warns when publishing files that contain.server.in their filename or are in aserverdirectory, as these are not protected from client-side imports when consumed fromnode_modules. The warning recommends using@sveltejs/kit/server-only