Skip to content

fix: resolve config paths only after we have root#16229

Draft
teemingc wants to merge 14 commits into
version-3from
fix-resolve-root
Draft

fix: resolve config paths only after we have root#16229
teemingc wants to merge 14 commits into
version-3from
fix-resolve-root

Conversation

@teemingc

@teemingc teemingc commented Jul 3, 2026

Copy link
Copy Markdown
Member

This PR separates the config processing from the validation because the processing needs to happen after we've retrieved the Vite root value. This is important for proper monorepo support. Otherwise, tooling such as our language tools and Vitest end up resolving file paths relative to where the process started rather than relative to the project root


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 3, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from eea4652:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/eea46521d0061e06db4edfeff422ece1380e5161

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16229

@changeset-bot

changeset-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eea4652

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

Comment thread packages/kit/src/exports/vite/index.js Outdated
Comment thread packages/kit/src/core/config/index.js Outdated
@teemingc teemingc marked this pull request as draft July 3, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant