fix: AsArgs default value type#15681
Conversation
🦋 Changeset detectedLatest commit: e3b6932 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I'm glad this is being worked on. It's been bugging me since release. const base = z.object({ /* some fields */})
const type1 = base.extend({
typeId: z.literal(1),
/* other fields */
})
const type2 = base.extend({
typeId: z.literal(2),
/* other fields */
})
const combined = z.discriminatedUnion('typeId',
[type1, type2]
)TS doesn't even accept literal values like
|
|
@paoloricciuti is this related to #15723, or are they completely different? |
|
Is there something we can add to the type tests? So we don't regress |
|
I think the additional issue mentioned in the PR description is still being worked on so I've changed this to a draft for now |
The current types are a bit weird to work with...since it's expecting something if you have a variable that can be
nullorundefinedit will yell at you (even tho it doesn't make sense sinceundefinedis technically an acceptable value).Furthermore the
(string | {})trick doesn't make sense here where the value can be anything (anumberfor example).There's still one issue that I wasn't fully able to solve yet: for
checkboxif you have abooleanvalue TS will complain becausebooleanis not assignable totrueandfalsewhich is what the type is expecting (actual strict values, not justboolean).Do you have any ideas on how to fix this?