Version 0.6.2 - #17
Merged
Merged
Conversation
sveinbjornt
force-pushed
the
new_release
branch
from
September 4, 2026 10:07
ba17c7d to
997260c
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The package version is 0.6.3 while the PR and changelog identify release 0.6.2.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates release metadata, Python support, CI, and database schema for version 0.6.2.
Changes:
- Raises minimum Python version to 3.10.
- Makes the placename table strict.
- Updates release history and development tooling.
File summaries
| File | Description |
|---|---|
README.md |
Documents Python 3.10 and release 0.6.2. |
pyproject.toml |
Updates version, Python requirement, and Ruff. |
add_placename_data.py |
Enables SQLite strict typing. |
.github/workflows/python-package.yml |
Tests Python 3.10 instead of 3.9. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sveinbjornt
force-pushed
the
new_release
branch
from
September 4, 2026 10:20
997260c to
8fe3079
Compare
Contributor
|
The one with heinum? |
Owner
Author
|
Yup, and some minor other fixes/improvements. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The proposed tolerance does not cover observed coordinate drift, and the type-checking changes are likely to break CI.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 11/12 changed files
- Comments generated: 3
- Review effort level: Balanced
| "pyright>=1.1.0", | ||
| "coverage[toml]>=7.3.1", | ||
| "ruff==0.15.16", | ||
| "pyright==1.1.0", |
| self.db_conn.row_factory = lambda c, r: dict( # type: ignore noqa: PGH003 | ||
| zip([col[0] for col in c.description], r) # type: ignore noqa: PGH003 | ||
| ) | ||
| self.db_conn.row_factory = lambda c, r: dict(zip([col[0] for col in c.description], r)) |
| # considered the intended one. Comfortably larger than the drift seen between | ||
| # releases of the source data, and comfortably smaller than the distance to the | ||
| # nearest rival placename of the same name (~10 km at the tightest). | ||
| _PRIORITY_MATCH_RADIUS_KM = 5.0 |
sveinbjornt
force-pushed
the
new_release
branch
from
September 4, 2026 13:36
2f84864 to
0e327ce
Compare
sveinbjornt
force-pushed
the
new_release
branch
from
September 4, 2026 15:02
0e327ce to
b86fab1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.