Skip to content

docs: stale pointers, tooling order, description triggers - #117

Merged
svedbg merged 1 commit into
mainfrom
docs/review-fixes-2.19.0
Sep 6, 2026
Merged

docs: stale pointers, tooling order, description triggers#117
svedbg merged 1 commit into
mainfrom
docs/review-fixes-2.19.0

Conversation

@svedbg

@svedbg svedbg commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes from an external review of 2.19.0 (7 points; excludes the big "ship more checks as code" item and the user_config/plugin-root point, which the review confirmed needs no action):

  • New references/uroci.md holds the concrete incident behind each of the two paid-refusal-run lessons; SKILL.md keeps only the bold lead sentence that PAID_GUIDANCE in test/skill_test.py protects against silent disappearance — trimmed, nothing lost.
  • Rule 2 ("изчисленията стават с код") now tells the model that scripts/ already covers preflight/k_checker/audit before asking it to write a new script — no longer contradicts step 4 further down.
  • Line 70's stale "apply checks row by row" pointer is fixed — checks have been an index into references/proverki/<letter>.md since 2.15.0.
  • .agents/ stub: "five files" corrected to "four" (consistent through the paragraph), and its frontmatter description synced verbatim with the canonical SKILL.md (was drifting, would have broken the description-match check).
  • compatibility now lists all four scripts under scripts/, not just the two named before the tools/scripts/ move.
  • description adds "декларация обр. 1 и обр. 6" (BG) and "Декларация обр. 1 or обр. 6" (EN) — the комплект suite's own documents are now part of the trigger, not just the internal cross-document check.

Test plan

  • test/skill_test.py — frontmatter caps, PAID_GUIDANCE survival, orphan-file check, Codex-pointer description match, date copies
  • test/rates_test.py
  • test/preflight_test.py
  • test/run_tests.py (suites 0-4, 50 seeds)
  • test/komplekt_test.py
  • test/lifecycle_test.py
  • test/eval_skill.py --selftest

🤖 Generated with Claude Code

https://claude.ai/code/session_01XvbzEbQwxwxxHAtXfPMrno

…ggers added

Отговор на външен преглед на 2.19.0 (7 точки, изключвайки „ship more checks
as code" и потвърждаването без промяна за user_config/plugin root):

- references/uroci.md поема конкретния случай зад двата отказни прогона,
  а SKILL.md пази само заглавието, което PAID_GUIDANCE следи — по-кратко,
  без да изчезва нищо.
- Второ правило вече казва, преди да поиска нов скрипт, че scripts/
  вече покрива preflight/k_checker/audit — редът вече не противоречи
  на стъпка 4.
- Ред 70 вече не казва „ред по ред" за проверки, които от 2.15.0 са
  индекс към references/proverki/<letter>.md.
- .agents/ стъбълото вече казва „четири" последователно (не „пет"),
  и description е синхронизиран дума по дума с каноничния SKILL.md.
- compatibility вече изброява всичките четири скрипта в scripts/, не
  само първите два от преди преместването от tools/.
- description добавя „декларация обр. 1 и обр. 6" (BG) и
  „Декларация обр. 1 or обр. 6" (EN) — комплектът вече е покрит от
  тригера, не само от вътрешната проверка.

test/skill_test.py, test/rates_test.py, test/preflight_test.py,
test/run_tests.py, test/komplekt_test.py, test/lifecycle_test.py и
test/eval_skill.py --selftest минават чисто.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XvbzEbQwxwxxHAtXfPMrno
@svedbg
svedbg merged commit c429bb8 into main Sep 6, 2026
12 checks passed
@svedbg
svedbg deleted the docs/review-fixes-2.19.0 branch September 6, 2026 11:45
@svedbg svedbg mentioned this pull request Sep 6, 2026
svedbg added a commit that referenced this pull request Sep 6, 2026
Version bump only, following the docs/prose PR (#117): fixed stale
references/proverki.md pointer, .agents/ description sync, tooling-order
clarification, description triggers for обр. 1/обр. 6, and
references/uroci.md split-out. No rule, rate or check behaviour changed —
patch bump.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XvbzEbQwxwxxHAtXfPMrno
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant