feat: ✨ support per-speed filtration pump power - #241
Draft
svasek wants to merge 2 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1607 1622 +15
=========================================
+ Hits 1607 1622 +15 ☔ View full report in Codecov by Harness. |
- add optional mid and low watt overrides for variable-speed pumps in the collapsed advanced options section - keep filtration_pump_power as the master switch and the high-speed value - select power by filtration_speed_state each update: off is 0 W, an empty or zero mid/low override falls back to the base value - leave existing single-value setups unchanged, so no options migration - add and localise strings for the two new fields - cover the selection logic with parametrised coordinator tests
svasek
force-pushed
the
feat/per-speed-pump-power
branch
from
July 24, 2026 21:10
a6e1975 to
9ff8e89
Compare
Owner
Author
|
/release-alpha |
|
🧪 Alpha pre-release created: To install via HACS:
|
svasek
marked this pull request as draft
July 28, 2026 10:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What
Add optional per-speed power values for variable-speed filtration pumps, so the energy estimate follows the running speed instead of a single fixed wattage.
Today a single
filtration pump poweroption unlocks the power and energy sensors. This adds two optional overrides for the medium and low speeds, refining the estimate for pumps that run at different RPM depending on cover state or schedule.🎯 Behaviour
The existing
filtration pump powerfield keeps two roles:filtration pump powerPower resolves from the reported
filtration_speed_stateeach update:offis 0 W, a running speed picks its override when non-zero, otherwise the base value. The pump being off always yields 0 W.Existing single-value setups behave exactly as before, so there is no options migration.
🛠️ Changes
filtration_pump_power_midandfiltration_pump_power_lowoption keys_compute_pump_powerhelper selects watts by running speed with fallback to the base value🧪 Testing
pytestall pass (336 passed, 17 snapshots)basedpyright0 errorsruff checkandruff format --checkclean📝 Notes
highoroff, so the overrides never apply.