chore(config): align default staleness to 500ms in dev and compose configs#2499
Open
Nachiket-Roy wants to merge 1 commit into
Open
chore(config): align default staleness to 500ms in dev and compose configs#2499Nachiket-Roy wants to merge 1 commit into
Nachiket-Roy wants to merge 1 commit into
Conversation
Signed-off-by: Nachiket Roy <nachiket.roy.2@gmail.com>
Nachiket-Roy
force-pushed
the
fix-staleness-default
branch
from
8681cba to
ab2a94a
Compare
Author
|
cc : @sunya-ch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the default value of
monitor.stalenessfrom1000msto500msinhack/config.yamland the Docker Compose config templates undercompose/.Rationale
This aligns the default values in these helper configuration files with the hardcoded programmatic default of
500msinconfig/config.go(DefaultConfig()) andinternal/monitor/options.go.This discrepancy was pointed out and discussed during the configuration documentation review in sustainable-computing-io/kepler-doc#201. Updating these templates resolves the inconsistency between the actual codebase defaults, the documentation, and these default config templates.
References