Fixed the SongPlaceholder Image not being able to load on Local (or undefined/missing) Songs.#1256
Open
Spikerko wants to merge 4 commits into
Open
Fixed the SongPlaceholder Image not being able to load on Local (or undefined/missing) Songs.#1256Spikerko wants to merge 4 commits into
Spikerko wants to merge 4 commits into
Conversation
Author
|
Also I have no idea why did the formatting of the code came out as it is right now |
That happened to me a few months ago too, anyway - when is this PR getting merged? This is kinda annoying. Was about to fix it myself. Edit: My bad, I didn't see if it was merged or not. This still happens to me even on the latest version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the currently playing song was Local (or
undefined), it just rendered a background without any image.This PR fixes the problem, by setting
crossOrigintoanonymousfor external images in the BG.