fix: publish wheels with metadata 2.5 without double-bumping - #91
Merged
Conversation
hatchling 1.32+ emits Metadata-Version 2.5; pin gh-action-pypi-publish to v1.14.2 and skip bump unless the trigger has a MAJOR/MINOR/PATCH token so v1.5.0 can reach PyPI without becoming 1.6.0. Co-authored-by: Cursor <cursoragent@cursor.com>
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pypa/gh-action-pypi-publishto v1.14.2 (dc37677) so hatchling ≥1.32 wheels with Metadata-Version 2.5 upload to PyPI.[MAJOR]/[MINOR]/[PATCH], and skip if HEAD aftergit pullis alreadychore(release):. Unblocks publishing existing v1.5.0 without bumping to 1.6.0.skip-existing: trueso a retry does not fail if the wheel is already on PyPI.Fixes failed publish job: https://github.com/supervaize/supervaizer/actions/runs/33161482947/job/98817032234
Do not re-run that failed workflow — it still has v1.14.1 and would bump again. Merge this PR to
main(no bump token in the title) so the new workflow publishes 1.5.0.Test plan
main(approvepypienvironment when publish waits)1.5.0(nochore(release): v1.6.0)supervaizer==1.5.0on PyPIv1.5.0existsjust ship-reconcileafter PyPI is liveMade with Cursor