Skip to content

fix(ci): route Dependabot PRs to develop, not main - #40

Merged
alain-sv merged 1 commit into
developfrom
fix/dependabot-target-develop
May 13, 2026
Merged

fix(ci): route Dependabot PRs to develop, not main#40
alain-sv merged 1 commit into
developfrom
fix/dependabot-target-develop

Conversation

@alain-sv

Copy link
Copy Markdown
Contributor

Summary

  • Add target-branch: "develop" to both pip and github-actions ecosystems in .github/dependabot.yml

Dependabot was defaulting to the repository's default branch (main) when creating update PRs. This routes all Dependabot update PRs to develop instead, consistent with the standard development flow for this repo.

Test plan

  • Verify the next Dependabot PRs are opened against develop

🤖 Generated with Claude Code

@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Route Dependabot PRs to develop branch

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Route Dependabot PRs to develop branch instead of main
• Add target-branch: "develop" to pip ecosystem configuration
• Add target-branch: "develop" to github-actions ecosystem configuration
Diagram
flowchart LR
  dependabot["Dependabot Updates"]
  config[".github/dependabot.yml"]
  pip["pip ecosystem"]
  actions["github-actions ecosystem"]
  develop["develop branch"]
  
  dependabot --> config
  config --> pip
  config --> actions
  pip -- "target-branch: develop" --> develop
  actions -- "target-branch: develop" --> develop
Loading

Grey Divider

File Changes

1. .github/dependabot.yml ⚙️ Configuration changes +2/-0

Configure Dependabot to target develop branch

• Added target-branch: "develop" to pip ecosystem configuration
• Added target-branch: "develop" to github-actions ecosystem configuration
• Ensures all Dependabot update PRs are created against develop branch instead of main

.github/dependabot.yml


Grey Divider

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented May 13, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Action required

1. Dependabot bypasses PR scan 🐞 Bug ⛨ Security
Description
With Dependabot now targeting develop, dependency update PRs will no longer trigger the
OSV-Scanner workflow because security-scan.yml only runs for pull requests against main,
allowing dependency updates to merge without PR-time vulnerability scanning.
Code

.github/dependabot.yml[5]

+    target-branch: "develop"
Evidence
Dependabot PRs will target develop due to the new target-branch setting, but the OSV security
scan workflow is configured to run on pull requests only when the base branch is main, so
develop-targeted Dependabot PRs will not run this scan. This also conflicts with the repo’s stated
posture that OSV-Scanner runs on every PR.

.github/dependabot.yml[1-8]
.github/dependabot.yml[23-28]
.github/workflows/security-scan.yml[3-9]
SECURITY.md[19-32]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
Dependabot PRs are now opened against `develop`, but the OSV security scan workflow only triggers on PRs targeting `main`. This means dependency update PRs (the ones most likely to introduce vulnerable packages) won’t receive the intended PR-time OSV scan.

### Issue Context
- Dependabot is configured to target `develop`.
- The OSV security workflow’s `pull_request` trigger is restricted to `branches: [main]`.
- Repository documentation claims OSV-Scanner runs “on every PR”, which won’t hold for `develop`-targeted PRs.

### Fix Focus Areas
- .github/workflows/security-scan.yml[3-9]
- .github/dependabot.yml[3-8]
- SECURITY.md[19-32]

### Suggested change
Update `.github/workflows/security-scan.yml` so `on.pull_request.branches` includes `develop` (e.g., `[develop, main]`). If you intentionally only want to scan `main`, then update `SECURITY.md` to reflect that OSV-Scanner is not run on every PR and consider an alternate mechanism to scan `develop` dependency PRs.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

Qodo Logo

Comment thread .github/dependabot.yml
updates:
- package-ecosystem: "pip"
directory: "/"
target-branch: "develop"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Dependabot bypasses pr scan 🐞 Bug ⛨ Security

With Dependabot now targeting develop, dependency update PRs will no longer trigger the
OSV-Scanner workflow because security-scan.yml only runs for pull requests against main,
allowing dependency updates to merge without PR-time vulnerability scanning.
Agent Prompt
### Issue description
Dependabot PRs are now opened against `develop`, but the OSV security scan workflow only triggers on PRs targeting `main`. This means dependency update PRs (the ones most likely to introduce vulnerable packages) won’t receive the intended PR-time OSV scan.

### Issue Context
- Dependabot is configured to target `develop`.
- The OSV security workflow’s `pull_request` trigger is restricted to `branches: [main]`.
- Repository documentation claims OSV-Scanner runs “on every PR”, which won’t hold for `develop`-targeted PRs.

### Fix Focus Areas
- .github/workflows/security-scan.yml[3-9]
- .github/dependabot.yml[3-8]
- SECURITY.md[19-32]

### Suggested change
Update `.github/workflows/security-scan.yml` so `on.pull_request.branches` includes `develop` (e.g., `[develop, main]`). If you intentionally only want to scan `main`, then update `SECURITY.md` to reflect that OSV-Scanner is not run on every PR and consider an alternate mechanism to scan `develop` dependency PRs.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@alain-sv
alain-sv force-pushed the fix/dependabot-target-develop branch from 7ab823d to 3218f79 Compare May 13, 2026 08:59
@alain-sv
alain-sv merged commit 7b10af4 into develop May 13, 2026
9 checks passed
@alain-sv
alain-sv deleted the fix/dependabot-target-develop branch May 13, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant