analytics_sdk - #30
Conversation
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1177ed0a9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "list_dashboards": True, | ||
| "get_dashboard": True, | ||
| "get_dataset": self.on_get_dataset is not None, |
There was a problem hiding this comment.
AnalyticsResource.operations always reports get_dashboard: True, but _make_get_dashboard_handler can only return a dashboard when on_get_dashboard is set or a static dashboard exists. Because check_dashboard_source allows list-only resources (on_list_dashboards without static dashboards), those resources advertise get_dashboard support yet every GET .../dashboards/{id} call returns 404. This breaks clients that trust the registration metadata and then fetch listed dashboard IDs individually.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 604ae6cdb7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| for dashboard in self.dashboards: | ||
| if not dashboard.get("id"): |
There was a problem hiding this comment.
AnalyticsResource validates that each static dashboard has an id, but it does not enforce uniqueness, so two entries can share the same id in dashboards. In that case list_dashboards can return both dashboards while get_static_dashboard always returns only the first match, making later duplicates unreachable and causing inconsistent client behavior when fetching a listed dashboard by id.
Useful? React with 👍 / 👎.
1 participant
Summary Expose analytics resourcesRelated changes- Update analytics changelog