✨ feat(agent): aync-control-event-http-client - #29
Merged
Conversation
Why: -_service.send_event is being converted to async API (-) and an explicit sync shim send_event_sync is provided for callers that need a blocking call. The agent code runs in contexts that may be synchronous; using the sync shim preserves existing behavior and avoids breaking callers.
…sive tests for data resource HTTP, including create, update, delete and permission-denied cases.ce helper_make_data_resource_server to a test Server Agent with an RSAprivate key configured API key to exercise endpoints withTest. Key changes: - Add tests verifying: - create callback must return a dict with 'id'returns500 otherwise). - update callback returning None leads to404. - delete callback returning leads404. -Error from a resource list callback403 with the original message. - Add _make_data_resource_server to reduce duplication when creating Server/Agent fixtures data resource tests. - Update test_workbench_routes imports to include additional types (Account, Case, CaseNodeUpdate, EntityStatus, Cases) and pytest-mock fixture importThese ensure consistent HTTP semantics and improve test for data resource handling in the API.
…ive unit tests for deploy.health: - introduce syncasync httpx client mocks and helpers testing- HealthConfig defaults and HealthCheckResult timestamp- test HealthVerifier behaviors: successful checks,, handling of error HTTP statuses, no-endpoint case, and request- add tests for display and verify_service_health utilitiesFix CHANGELOG: - remove stray "Name Stmts Miss Cover" header and duplicate coverage summary lines to clean up outputThese changes improve test coverage for health verification logicand make release notes/changelog formatting consistent.
…LOG.md reflect new test run results and improve thecoverage report formatting. - B passed tests from532 to559 and add a "with" runtime row. - Remove stalein time and add clearer timing field (102s). - Replace plain coverage list with a formatted Markdown table showing Name, Stmts, Miss, and Cover for. - Fix alignment and header spacing in the reportThese changes keep the changelog accurate and make coverage outputeasier to read for contributors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
-_service.send_event is being converted to async API (-) and an explicit sync shim send_event_sync is provided for callers that need a blocking call.
The agent code runs in contexts that may be synchronous; using the sync shim preserves existing behavior and avoids breaking callers.