✨feat(api): agent custom routes under /api/agentsAllow agentvided FastAPI routers to mounted consistently under/api/agents/{slug}/... and update and metadata to reflect thecanonical path. Thisifies the API and avoids ambiguity aboutwhere custom agent live. - #26
Merged
Conversation
…tAPI routers to mounted consistently under/api/agents/{slug}/... and update and metadata to reflect thecanonical path. Thisifies the API and avoids ambiguity aboutwhere custom agent live.
- Update README, docs/model_reference, and agent Field description to
state custom routes are mounted underapiagentsslug}/...
Clar router comment in src/supervaizer/routers/api to document the full
path for nested agent routes🔧fix(access): simplify Tailscale access
and clarify behaviorReject non-Tailscale clients uniformly (including
WebSocket upgraderequests) by raising403 during the handshake rather
than trying tomanually close websockets Simplify logic and ensure
consistent errorhandling and logging.
- Remove WebSocketState-specific branch in
srcupervaizer/access/tailscale.py- Ensure docstring states WebSocket
upgrade are rejected before connection is established🧪test: add
validation for require_scope wiringAdd a unit test to ensure invalid
or unknown scopes raise dependencycreation time to catch typos and
wiring errors early.
- Add pytest import and test_unknown_required_scope_raises_at in
tests/test_access_api_auth.pyOther- Minor formatting/wording tweaks.
…nknown_required_raises_at_creationmethod signature to a-line parameter layout. This change improves codereadability and aligns the test with the project's formatting standards forlong signatures. No behavioral changes introduced onlywh and line breaking are to make the clearer and moreainable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update README, docs/model_reference, and agent Field description to
state custom routes are mounted underapiagentsslug}/...
Clar router comment in src/supervaizer/routers/api to document the full
path for nested agent routes🔧fix(access): simplify Tailscale access
and clarify behaviorReject non-Tailscale clients uniformly (including
WebSocket upgraderequests) by raising403 during the handshake rather
than trying tomanually close websockets Simplify logic and ensure
consistent errorhandling and logging.
Remove WebSocketState-specific branch in
srcupervaizer/access/tailscale.py- Ensure docstring states WebSocket
upgrade are rejected before connection is established🧪test: add
validation for require_scope wiringAdd a unit test to ensure invalid
or unknown scopes raise dependencycreation time to catch typos and
wiring errors early.
Add pytest import and test_unknown_required_scope_raises_at in
tests/test_access_api_auth.pyOther- Minor formatting/wording tweaks.