✨ feat: add for admin IP allowlist middleware comprehensive unit tests the admin IP allowlist feature toensure correct behaviour of middleware and helper functions. - #18
Merged
Conversation
…s the admin IP allowlist feature toensure correct behaviour of middleware and helper functions. - Add tests for is_admin_url_path covering root, nested and similar non-admin paths. - Add tests for client_ip_is_allowed covering empty env, IP matches, CIDR ranges and multiple entries. - tests get_effective_client_ip to prefer-ForwardedFor and fallback to theGI client address- Add integration tests using a minimal Fast app with the AdminIPAllowlistMiddleware applied to verify: ADMIN_ALLOWED_IPS unset allows requests. - Requests are blocked when client IP is not in the allowlist. - Requests are allowed when client IP is in the allowlist. - Non-admin paths remain. - Provide a minimal_admin_app fixture that patches storage and sets necessary app.state.server for isolated testing. These tests improve coverage and prevent regress in IP-basedadministration access control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADMIN_ALLOWED_IPS unset allows requests.
These tests improve coverage and prevent regress in IP-basedadministration access control.