refactor: use native RHCS provider auto_node for AutoNode/Karpenter - #53
Merged
Conversation
Replace the manual `rosa edit cluster --autonode=enabled` CLI step with the native `auto_node` attribute on `rhcs_cluster_rosa_hcp` (added in provider 1.7.5). This simplifies from a 3-phase to 2-phase deployment. Key changes: - modules/cluster/autonode: make cluster_id optional (IAM-only mode) - modules/cluster/rosa-hcp: add autonode_role_arn and fips variables - environments/commercial-hcp: move autonode IAM before cluster, pass role_arn to auto_node block, add inline subnet tags post-cluster - Remove cluster_properties/provision_shard_id workaround (no longer needed now that AutoNode is GA with native provider support) - Wire fips=true for govcloud-hcp (mandatory for FedRAMP) - Update docs and examples for simplified 2-phase workflow Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the manual
rosa edit cluster --autonode=enabledCLI step with the nativeauto_nodeattribute onrhcs_cluster_rosa_hcp(added in provider 1.7.5). This simplifies from a 3-phase to 2-phase deployment.Key changes: