Fix Sprite URL domain: .sprites.app -> .sprites.dev#205
Closed
kcmartin wants to merge 2 commits into
Closed
Conversation
Contributor
Preview Deployment
Commit: |
Contributor
Lighthouse Results
|
Contributor
E2E Test Results✅ Tests success Ran against: https://pr-205-superfly-sprites-docs.fly.dev |
Collaborator
Author
|
This was opened in error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sprite URL domain is
.sprites.dev(confirmed against the live rc44 CLI), but two hand-written pages still used the stale.sprites.app.What changed
working-with-sprites.mdx: URL example in the Networking section.reference/configuration.mdx: Sprite URL entry under Network Configuration.Not touched (generated)
cli/commands.mdxandapi/*/sprites.mdxalso contain.sprites.app, but they're auto-generated (scripts/generate-cli-docs,generate-api-docs.ts). The live CLI already emits.sprites.dev, socli/commands.mdxcorrects itself on the next regen; the API examples need the fix upstream in the schema. Hand-editing generated files would be clobbered, so they're left for a regen pass.