docs(examples): add Sign in with MetaMask (SIWE) example#1139
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Examples app now links the Sequence Diagram(s)sequenceDiagram
participant SignInWithMetaMaskView
participant SignInWithMetaMaskController
participant MetaMaskSDK
participant SupabaseAuth
SignInWithMetaMaskView->>SignInWithMetaMaskController: Start connection or sign-in
SignInWithMetaMaskController->>MetaMaskSDK: Connect or request personal_sign
MetaMaskSDK-->>SignInWithMetaMaskController: Return account, chain, signature, or callback URL
SignInWithMetaMaskController->>SupabaseAuth: Submit Web3 credentials
SupabaseAuth-->>SignInWithMetaMaskView: Display session or error
Possibly related PRs
Suggested labels: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
The following capabilities are marked
These may have been renamed, removed, or never registered. Please update the capability matrix. |
grdsdev
changed the title
grdsdev
marked this pull request as ready for review
July 22, 2026 15:37
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Examples/Examples/Auth/SignInWithMetaMask.swift`:
- Around line 81-82: Update the signRequest construction in the
SignInWithMetaMask flow to pass personalSign parameters in the required order:
address first, followed by message. Keep the existing EthereumRequest and
metamaskSDK.request flow unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d35e1f4a-156f-4f60-ad73-a619ace9320a
⛔ Files ignored due to path filters (2)
Package.resolvedis excluded by!**/Package.resolvedSupabase.xcworkspace/xcshareddata/swiftpm/Package.resolvedis excluded by!**/Package.resolved
📒 Files selected for processing (14)
Examples/Examples.xcodeproj/project.pbxprojExamples/Examples/Auth/AuthExamplesView.swiftExamples/Examples/Auth/SignInWithMetaMask.swiftExamples/Examples/Info.plistExamples/README.mdPackage.swiftSources/Auth/AuthClient.swiftSources/Auth/AuthError.swiftSources/Auth/Types.swiftTests/AuthTests/AuthClientTests.swiftTests/IntegrationTests/AuthClientIntegrationTests.swiftTests/IntegrationTests/supabase/config.tomldictionary.txtsdk-compliance.yaml
spydon
approved these changes
Jul 22, 2026
Contributor
There was a problem hiding this comment.
I thought Solana wasn't supported? As per the PR description at least
There was a problem hiding this comment.
i think it's supported in the auth server at least
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
I guess the PR description was just not accurate then
mandarini
approved these changes
Jul 22, 2026
grdsdev
force-pushed
the
claude/web3-signin-metamask-example
branch
from
July 22, 2026 16:36
19ea10c to
5197c08
Compare
Coverage Report for CI Build 29960064069Coverage decreased (-0.2%) to 83.628%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions17 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
grdsdev
enabled auto-merge (squash)
July 22, 2026 16:38
The SIWE message hardcoded `URI: https://supabase.com`, which the backend rejects with `invalid_grant` ("message was signed for another app") for any real project, since that URI is never on a project's own redirect allow-list. Switch to `http://localhost:3000`, matching the placeholder already used by this SDK's own integration tests, and document the required Additional Redirect URLs entry in the README.
grdsdev
force-pushed
the
claude/web3-signin-metamask-example
branch
from
July 22, 2026 21:39
5197c08 to
afc00aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #1138 (adds
AuthClient.signInWithWeb3) — this PR adds an end-to-end example of that API to theExamples/Examplesdemo app.ExamplesXcode target — no new target.Examples/Examples/Auth/SignInWithMetaMask.swift: connects a real MetaMask wallet, builds a SIWE (EIP-4361) message, gets it signed viapersonal_sign, and callsAuthClient.signInWithWeb3.#if canImport(UIKit)-gated), matching the existingSignInWithOAuthViewControllerexample's platform scoping.Two non-obvious correctness details worth knowing about, both verified against the MetaMask SDK's real source and this repo's own
signInWithWeb3backend contract:personal_signparams are sent as[message, address]— the SDK's ownpersonalSign(message:address:)convenience method sends the opposite order ([address, message]), which contradicts both the JSON-RPC spec and the SDK's own example app. This PR builds the request manually with the correct order.chainIdis hex (e.g.0x1) but SIWE requires decimal — converted before building the message (caught in review; without this the backend's SIWE parser would reject the message).Test plan
xcodebuild -workspace Supabase.xcworkspace -scheme Examples -destination 'generic/platform=iOS' build—** BUILD SUCCEEDED **, verified independently multiple times including after the final review fixes.Manual e2e test
ScreenRecording_07-22-2026.12-31-50_1.MP4