Skip to content

fix: preserve equals signs in role config values - #1119

Open
hsusul wants to merge 1 commit into
supabase:masterfrom
hsusul:fix/preserve-role-config-equals
Open

fix: preserve equals signs in role config values#1119
hsusul wants to merge 1 commit into
supabase:masterfrom
hsusul:fix/preserve-role-config-equals

Conversation

@hsusul

@hsusul hsusul commented Aug 27, 2026

Copy link
Copy Markdown

Fixes #1117

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Role configuration parsing splits each rolconfig entry on every equals sign and keeps only the first value segment. A value such as application_name=api=worker is returned as api.

What is the new behavior?

The parser treats only the first equals sign as the key/value delimiter and preserves the rest of the value verbatim. Existing behavior for ordinary and delimiter-free entries remains unchanged.

Tests

Added focused coverage for values containing additional equals signs and for the existing delimiter-free behavior.

Local validation:

  • npx vitest run test/roles-config.test.ts — 2 passed
  • npm run check — passed
  • npm run build — passed
  • Prettier check — passed
  • git diff --check — passed

Docker-backed integration tests were unavailable because the local Docker daemon is not running.

Additional context

Open #1091 touches a separate null guard in role config updates; it does not change rolconfig response parsing.

Signed-off-by: Henry Su <henrysu4707@gmail.com>
@hsusul
hsusul requested review from a team, avallete and soedirgo as code owners August 27, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Role config values containing equals signs are truncated

1 participant