fix: preserve equals signs in role config values - #1119
Open
hsusul wants to merge 1 commit into
Open
Conversation
Signed-off-by: Henry Su <henrysu4707@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1117
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Role configuration parsing splits each rolconfig entry on every equals sign and keeps only the first value segment. A value such as application_name=api=worker is returned as api.
What is the new behavior?
The parser treats only the first equals sign as the key/value delimiter and preserves the rest of the value verbatim. Existing behavior for ordinary and delimiter-free entries remains unchanged.
Tests
Added focused coverage for values containing additional equals signs and for the existing delimiter-free behavior.
Local validation:
Docker-backed integration tests were unavailable because the local Docker daemon is not running.
Additional context
Open #1091 touches a separate null guard in role config updates; it does not change rolconfig response parsing.