fix: preserve identity generation when it is omitted from column updates - #1116
Open
hsusul wants to merge 1 commit into
Open
fix: preserve identity generation when it is omitted from column updates#1116hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
The update default of BY DEFAULT made SET GENERATED fire on unrelated PATCHes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
Why?
columns.updatedefaultedidentity_generationto'BY DEFAULT'. The in-file state table says that omitting it on an existing identity column should emit noSET GENERATED, but the default made that branch unreachable. A comment-only PATCH therefore rewroteGENERATED ALWAYStoBY DEFAULT.POST /columnsstill defaults omitted generation toBY DEFAULT(#77).Fixes #1114.
How?
Remove the update-path default. Keep
SET GENERATEDonly whenidentity_generationis provided. When adding identity, fall back toBY DEFAULTif generation is omitted.Checklist