fix: retrieve the zero-argument function overload when args is empty - #1112
Open
hsusul wants to merge 1 commit into
Open
fix: retrieve the zero-argument function overload when args is empty#1112hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
functions.retrieve skipped the proargtypes filter for args: [], so overloaded names could return the wrong signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
Why?
functions.retrieve({ schema, name, args: [] })is documented by the existing tests as selecting the zero-argument overload.FUNCTIONS_SQLskipped theproargtypespredicate wheneverargswas empty, so overloaded names returneddata[0]instead of the no-arg signature.functions.create()looks the function up the same way afterCREATE FUNCTION, so creating a zero-argument overload of an existing name could also return the wrong row.Fixes #1111.
How?
When
argsis provided, always filter onp.proargtypes::text. Non-empty argument lists still resolve type OIDs the same way;args: []now compares against the emptyoidvector(''), which was already present as dead code.Checklist
New tests
retrieve function by args filter - zero-argument overload among polymorphic functionsuses the existingpolymorphic_function_with_no_params_or_unnamedfixtures. Before the fix it received thetextoverload; after the fix it receives the zero-argumentintegeroverload.