docs: sync READMEs with implementation, export ConsentState from client - #11
Merged
Conversation
…lient - Add missing sgtm plugin to root README (package description, plugin table, setUser mapping table, event mapping section) - Add 5 missing events (login, share, view_search_results, add_to_wishlist, view_cart) to Supported Events tables in root and core READMEs, matching the 21-event EventMap - Re-export ConsentState/ConsentStatus types from @sunwjy/funnel-client so the documented setConsent plugin hook is typeable by consumers - Replace Pre-release Backlog with TODO, dropping completed items Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sgtm플러그인 문서화 (플러그인 테이블,setUser매핑 테이블, 이벤트 매핑 섹션)EventMap(21개)에는 있지만 빠져 있던 5개 이벤트 추가:login,share,view_search_results,add_to_wishlist,view_cart(루트 + core README)@sunwjy/funnel-client에서ConsentState/ConsentStatus타입 re-export — 문서화된setConsent플러그인 훅을 소비자가 타이핑할 수 있도록Verification
pnpm build5/5,pnpm typecheck7/7,pnpm test429/429,pnpm lint통과🤖 Generated with Claude Code