Skip to content

Added extra slice hook useful for downstream#944

Open
nabobalis wants to merge 1 commit into
sunpy:mainfrom
nabobalis:getitem
Open

Added extra slice hook useful for downstream#944
nabobalis wants to merge 1 commit into
sunpy:mainfrom
nabobalis:getitem

Conversation

@nabobalis

Copy link
Copy Markdown
Member

PR Description

any NDCube subclass holding axis-tracking state that NDMeta's generic slicing can't express (per-frame WCS lists, instrument lookup tables that change meaning when an axis collapses) currently must override getitem, duplicate the mixin's ellipsis/sanitize logic, and hope upstream slicing internals don't shift under them. One no-op hook removes that entire class of override.

ALL TO MAKE MY IRISPY PR SMALLER.

AI Assistance Disclosure

AI tools were used for:

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding
  • No AI tools were used

Regardless of AI use, the human contributor remains fully responsible for correctness, design choices, licensing compatibility, and long-term maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant