Store failure exception with cause on result#220
Open
branson-simplethread wants to merge 1 commit into
Open
Conversation
branson-simplethread
force-pushed
the
capture-exception-on-fail
branch
from
92040c3 to
582fd62
Compare
branson-simplethread
force-pushed
the
capture-exception-on-fail
branch
from
582fd62 to
0a437cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! 👋
The goal of this change is to make raised exceptions available to the caller of
Actor#result. Additionally, exceptions rescued withfail_onare captured as thecauseof the configured failure class.I'm not too attached to the implementation here, so I'd appreciate your thoughts! But I found this necessary for some work I'm doing and had to patch
ServiceActor::Failable.